Skip to content

Conversation

@Lucas7yoshi
Copy link
Contributor

Summary

Corrects references to the CTRL key as CTL in System.Windows.Forms.Control.DoDragDrop
I was not able to find any information that would suggest this is correct.

@Lucas7yoshi Lucas7yoshi requested a review from a team as a code owner October 20, 2021 04:17
@dnfadmin
Copy link

dnfadmin commented Oct 20, 2021

CLA assistant check
All CLA requirements met.

@opbld31
Copy link

opbld31 commented Oct 20, 2021

Docs Build status updates of commit f6eecd0:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/cpp/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/CPP/form1.cpp ✅Succeeded View
samples/snippets/csharp/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/CS/form1.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/VB/form1.vb ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@BillWagner
Copy link
Member

@adegeo Can you check this one?

@adegeo
Copy link
Contributor

adegeo commented Oct 21, 2021

The error isn't a false positive. These have no projects. The code needs to be upgraded.

@adegeo
Copy link
Contributor

adegeo commented Oct 21, 2021

Oh, whoops. I thought you were looking for why the snippets build was failing. 😁

It's just updating some code comments using CTRL to identify the keyboard key.

@gewarren @BillWagner Are we currently requiring minor updates like this to be recreated with full code examples?

@Lucas7yoshi
Copy link
Contributor Author

If I need to link these to some sort of project, I can give it a shot. I am not too familiar with c++ though.

If there's any documentation regarding making said projects, send it my way and I can see if it's within my ability.

@gewarren
Copy link
Contributor

I think we can let this change go without adding a project file since it's literally just updating code comments.

@gewarren
Copy link
Contributor

Although now that I look at the code, I'm not sure that e.KeyState is correct - shouldn't it be e.KeyStates? See https://docs.microsoft.com/en-us/dotnet/api/system.windows.drageventargs.keystates?view=windowsdesktop-5.0#System_Windows_DragEventArgs_KeyStates.

@Lucas7yoshi
Copy link
Contributor Author

Although now that I look at the code, I'm not sure that e.KeyState is correct - shouldn't it be e.KeyStates? See https://docs.microsoft.com/en-us/dotnet/api/system.windows.drageventargs.keystates?view=windowsdesktop-5.0#System_Windows_DragEventArgs_KeyStates.

I loaded up the c# sample and am not seeing any issue stemming from the usage of e.KeyState, atleast on net framework 4.8.

No plural form being made known to me by VS.

@gewarren gewarren merged commit a2fd5a7 into dotnet:main Oct 21, 2021
@adegeo
Copy link
Contributor

adegeo commented Oct 22, 2021

@gewarren That API is the WPF API, this is the WinForms API which is probably why it's named slightly different. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants